Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): pyenv manager #10128

Merged
merged 5 commits into from Jun 1, 2021
Merged

Conversation

caiofbpa
Copy link
Contributor

@caiofbpa caiofbpa commented May 24, 2021

Changes:

This PR adds support for updating .python-version files which are used by pyenv to determine current Python version.

Context:

Renovate updates python versions on Dockerfile but not on .python-version, causing possible mismatch between development and production versions.

Closes #9757

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

lib/manager/pyenv/extract.ts Outdated Show resolved Hide resolved
lib/manager/pyenv/extract.ts Show resolved Hide resolved
@viceice
Copy link
Member

viceice commented May 24, 2021

@rarkins maybe we should use our python prebuild from containerbase as datasource? It's a little slower than normal python releases.

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@rarkins rarkins changed the title Support pyenv manager feat(python): pyenv manager May 24, 2021
@rarkins
Copy link
Collaborator

rarkins commented May 24, 2021

@rarkins maybe we should use our python prebuild from containerbase as datasource? It's a little slower than normal python releases.

Can we work out if the Docker images are delayed anyway?

@caiofbpa
Copy link
Contributor Author

Anyone can help me fix that lib/manager/index.spec.ts#L39 failing test?

@viceice
Copy link
Member

viceice commented May 25, 2021

Anyone can help me fix that lib/manager/index.spec.ts#L39 failing test?

You need to add the new manager to the api.ts

import * as regex from './regex';

api.set('regex', regex);

@caiofbpa
Copy link
Contributor Author

@viceice thanks for the guidance, now the tests should pass. Any direction regarding changing the Docker datasource to something else?

@caiofbpa
Copy link
Contributor Author

caiofbpa commented Jun 1, 2021

Just a gentle ping on @viceice and @rarkins to check wether we can merge this as is, or what better datasource can be used for Python here as I have no idea

@rarkins rarkins merged commit 0534aea into renovatebot:main Jun 1, 2021
@caiofbpa caiofbpa deleted the support-pyenv-manager branch June 1, 2021 13:08
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pyenv (.python-version) support
4 participants