feat(gradle): merge gradle-lite into gradle #10132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
previously approved these changes
May 25, 2021
HonkingGoose
suggested changes
May 25, 2021
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
HonkingGoose
previously approved these changes
May 25, 2021
zharinov
reviewed
May 25, 2021
| }; | ||
| return config.deepExtract | ||
| ? deep.extractAllPackageFiles(config, packageFiles) | ||
| : shallow.extractAllPackageFiles(config, packageFiles); |
There was a problem hiding this comment.
That's good it's only can be either deep or shallow, not both. I doubt the reasonable mixed solution is possible.
|
I'm not sure if this is |
JamieMagee
reviewed
Jun 4, 2021
| name: 'deepExtract', | ||
| description: `Enable extraction of dependencies using package managers.`, | ||
| type: 'boolean', | ||
| default: false, |
There was a problem hiding this comment.
If you're not ready to merge a breaking change yet, I'd recommend setting this to true, merging this PR as a non-breaking change, and then open another one which is marked as breaking where you change this to false.
Lowers the risk of getting merge conflicts if you want to wait and collect many breaking changes into a single release.
…le-lite # Conflicts: # lib/manager/gradle/deep/index.spec.ts # lib/manager/gradle/deep/utils.ts
# Conflicts: # lib/manager/gradle-lite/readme.md
rarkins
added a commit
that referenced
this pull request
Jul 28, 2021
Removes standalone gradle-lite manager and merges it into the gradle manager as the default behavior, while adding deepExtract as an option to re-enable previous behavior. Closes #10091 BREAKING CHANGE: Gradle extraction now defaults to JS-based parsing (previously "gradle-lite")
rarkins
added a commit
that referenced
this pull request
Jul 29, 2021
Removes standalone gradle-lite manager and merges it into the gradle manager as the default behavior, while adding deepExtract as an option to re-enable previous behavior. Closes #10091 BREAKING CHANGE: Gradle extraction now defaults to JS-based parsing (previously "gradle-lite")
rarkins
added a commit
that referenced
this pull request
Aug 2, 2021
Removes standalone gradle-lite manager and merges it into the gradle manager as the default behavior, while adding deepExtract as an option to re-enable previous behavior. Closes #10091 BREAKING CHANGE: Gradle extraction now defaults to JS-based parsing (previously "gradle-lite")
rarkins
added a commit
that referenced
this pull request
Aug 9, 2021
Removes standalone gradle-lite manager and merges it into the gradle manager as the default behavior, while adding deepExtract as an option to re-enable previous behavior. Closes #10091 BREAKING CHANGE: Gradle extraction now defaults to JS-based parsing (previously "gradle-lite")
rarkins
added a commit
that referenced
this pull request
Aug 13, 2021
Removes standalone gradle-lite manager and merges it into the gradle manager as the default behavior, while adding deepExtract as an option to re-enable previous behavior. Closes #10091 BREAKING CHANGE: Gradle extraction now defaults to JS-based parsing (previously "gradle-lite")
rarkins
added a commit
that referenced
this pull request
Aug 13, 2021
Removes standalone gradle-lite manager and merges it into the gradle manager as the default behavior, while adding deepExtract as an option to re-enable previous behavior. Closes #10091 BREAKING CHANGE: Gradle extraction now defaults to JS-based parsing (previously "gradle-lite")
rarkins
added a commit
that referenced
this pull request
Aug 15, 2021
Removes standalone gradle-lite manager and merges it into the gradle manager as the default behavior, while adding deepExtract as an option to re-enable previous behavior. Closes #10091 BREAKING CHANGE: Gradle extraction now defaults to JS-based parsing (previously "gradle-lite")
rarkins
added a commit
that referenced
this pull request
Aug 16, 2021
Removes standalone gradle-lite manager and merges it into the gradle manager as the default behavior, while adding deepExtract as an option to re-enable previous behavior. Closes #10091 BREAKING CHANGE: Gradle extraction now defaults to JS-based parsing (previously "gradle-lite")
rarkins
added a commit
that referenced
this pull request
Aug 17, 2021
Removes standalone gradle-lite manager and merges it into the gradle manager as the default behavior, while adding deepExtract as an option to re-enable previous behavior. Closes #10091 BREAKING CHANGE: Gradle extraction now defaults to JS-based parsing (previously "gradle-lite")
rarkins
added a commit
that referenced
this pull request
Aug 17, 2021
Removes standalone gradle-lite manager and merges it into the gradle manager as the default behavior, while adding deepExtract as an option to re-enable previous behavior. Closes #10091 BREAKING CHANGE: Gradle extraction now defaults to JS-based parsing (previously "gradle-lite")
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Removes standalone
gradle-litemanager and merges it into thegradlemanager as the default behavior, while addingdeepExtractas an option to re-enable previous behavior.Context:
Closes #10091
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: