Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add core: labels to issue labeling guide #10349

Merged
merged 4 commits into from Jun 14, 2021
Merged

docs: add core: labels to issue labeling guide #10349

merged 4 commits into from Jun 14, 2021

Conversation

HonkingGoose
Copy link
Collaborator

Changes:

  • Add the new core: labels to the issue labeling guide

Context:

Based on the discussion #10347.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

HonkingGoose
HonkingGoose commented Jun 8, 2021
View reviewed changes
Copy link
Collaborator Author

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not ready for merge yet, as we need to explain when to apply core: labels properly still.

docs/development/issue-labeling.md Outdated Show resolved Hide resolved
docs/development/issue-labeling.md Outdated Show resolved Hide resolved
@rarkins rarkins marked this pull request as ready for review June 14, 2021 11:38
HonkingGoose
HonkingGoose commented Jun 14, 2021
View reviewed changes
Copy link
Collaborator Author

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go! Just one thing to check. 😉

docs/development/issue-labeling.md Outdated Show resolved Hide resolved
rarkins and others added 2 commits June 14, 2021 16:02
@rarkins @HonkingGoose
Update docs/development/issue-labeling.md
932503d 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@rarkins
Merge branch 'main' into docs/document-new-core-tags
85d2beb
@rarkins rarkins enabled auto-merge (squash) June 14, 2021 14:02
@rarkins rarkins merged commit 5250d07 into renovatebot:main Jun 14, 2021
@HonkingGoose HonkingGoose deleted the docs/document-new-core-tags branch June 14, 2021 14:19
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.41.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HonkingGoose @renovate-release @rarkins