Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pip_requirements): extractAllPackageFiles #10414

Merged
merged 2 commits into from Jun 14, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jun 12, 2021

Changes:

Refactors pip_requirements manager to use extractAllPackageFiles().

Context:

Refactoring to prepare for full pip-compile support.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins merged commit 015391c into main Jun 14, 2021
@rarkins rarkins deleted the refactor/pip-requirements-extract-all branch June 14, 2021 06:55
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.41.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

rarkins added a commit that referenced this pull request Jun 18, 2021
export { extractPackageFile } from './extract';
export { extractAllPackageFiles } from './extract';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rarkins You need to export both functions to get it working with auto-replace

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I decided to revert it for now as the quickest resolution

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants