Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lein): Support version variables #10479

Merged
merged 6 commits into from
Jun 18, 2021

Conversation

zharinov
Copy link
Collaborator

Changes:

Add support for (def foo "bar") instructions before defproject call.

Context:

Closes #10436

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Example: https://github.com/renovate-testing/test-10436-lein-vars/pull/1/files

@zharinov zharinov changed the title Feat/lein var defs feat(leiningen): Support version variables Jun 17, 2021
@zharinov zharinov changed the title feat(leiningen): Support version variables feat(lein): Support version variables Jun 17, 2021
@zharinov
Copy link
Collaborator Author

Waiting for #10477

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs deconflicting

@rarkins rarkins enabled auto-merge (squash) June 18, 2021 06:45
@rarkins rarkins merged commit 969ea18 into renovatebot:main Jun 18, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.47.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Clojure+lein dependencies aren't picked up if defined outside the defproject
4 participants