Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Platform.mergePr args to object #10830

Closed
viceice opened this issue Jul 14, 2021 · 2 comments · Fixed by #11155
Closed

Refactor Platform.mergePr args to object #10830

viceice opened this issue Jul 14, 2021 · 2 comments · Fixed by #11155
Assignees
@pret-a-porter
Labels
good first issue Suitable for new contributors priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code

Comments

@viceice
Copy link
Member

viceice commented Jul 14, 2021

@rarkins i think we should refactor this to object arg after this pr

Originally posted by @viceice in #10627 (comment)
@viceice viceice added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:ready type:refactor Refactoring or improving of existing code labels Jul 14, 2021
@viceice viceice mentioned this issue Jul 14, 2021
Merged
6 tasks
This was referenced Jul 15, 2021
Open
Closed
Open
Open
@rarkins rarkins added the good first issue Suitable for new contributors label Jul 26, 2021
@pret-a-porter
Copy link
Contributor

@rarkins I will take this one

@pret-a-porter pret-a-porter mentioned this issue Aug 7, 2021
Merged
5 tasks
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 25.70.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pret-a-porter pret-a-porter

Labels
good first issue Suitable for new contributors priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(platform): mergePr args to object pret-a-porter/renovate
4 participants
@viceice @rarkins @pret-a-porter @renovate-release