Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(bitbucket-tags): move datasource to class #10957

Merged
merged 4 commits into from Jul 29, 2021
Merged

refactor(bitbucket-tags): move datasource to class #10957

merged 4 commits into from Jul 29, 2021

Conversation

secustor
Copy link
Collaborator

Changes:

Moves the BitBucketTags datasource to the class based approach

Context:

#8647

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from JamieMagee July 25, 2021 04:28
JamieMagee
JamieMagee previously approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@JamieMagee JamieMagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small comments. Overall good to go!

@viceice viceice changed the title refactor(BitBucketTags): move datasource to class refactor(bitbucket-tags): move datasource to class Jul 29, 2021
@viceice viceice enabled auto-merge (squash) July 29, 2021 08:01
@viceice viceice merged commit e631cae into renovatebot:main Jul 29, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.60.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

viceice added a commit that referenced this pull request Jul 30, 2021
@secustor @JamieMagee @viceice
refactor(bitbucket-tags): move datasource to class (#10957)
49e2fd8 
Co-authored-by: Jamie Magee <jamie.magee@gmail.com>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2021
@secustor secustor deleted the move-bitbuckettags-to-class branch December 4, 2022 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins left review comments

@JamieMagee JamieMagee JamieMagee approved these changes

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@secustor @renovate-release @JamieMagee @viceice @rarkins