Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gomod): revert auth changes #11021

Merged
merged 1 commit into from Jul 30, 2021
Merged

fix(gomod): revert auth changes #11021

merged 1 commit into from Jul 30, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jul 30, 2021

Changes:

Reverts gomod auth changes from #10750

Context:

The changes have broken private go modules on github.com (for the app at least)

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice July 30, 2021 10:14
@rarkins
Copy link
Collaborator Author

rarkins commented Jul 30, 2021

@Shegox FYI. After consulting with @viceice we decided the changes required are too significant to rush, so we prefer to revert this now in a patch

@rarkins rarkins enabled auto-merge (squash) July 30, 2021 10:20
@rarkins rarkins merged commit f0e1070 into main Jul 30, 2021
@rarkins rarkins deleted the fix/revert-go-auth-changes branch July 30, 2021 10:23
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.61.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants