feat(rubygems): support GitHub Packages #11107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub Packages doesn't seem to expose neither /api/v1/gems or /versions endpoints. It instead uses /api/v1/dependencies to answer queries from bundler. See https://andre.arko.net/2014/03/28/the-new-rubygems-index-format/ for the differences between these APIs. This commit adds fallback from /api/v1/gems/*.json to /api/v1/dependencies to support GitHub Packages. It involves parsing Ruby's Marshal format, so I created @qnighy/marshal for the purpose.
|
|
viceice
requested changes
Aug 5, 2021
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Then I'll use |
|
Will work on |
6 tasks
It seems getBuffer() returns an empty Buffer for an empty response.
|
Moved to |
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice
reviewed
Aug 12, 2021
viceice
reviewed
Aug 13, 2021
7 tasks
viceice
reviewed
Aug 13, 2021
viceice
previously approved these changes
Aug 13, 2021
Unfortunately, I don't know a public one... |
viceice
previously approved these changes
Aug 13, 2021
rarkins
previously requested changes
Aug 13, 2021
viceice
reviewed
Aug 19, 2021
viceice
reviewed
Aug 19, 2021
viceice
approved these changes
Aug 19, 2021
|
🎉 This PR is included in version 26.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Thanks a lot for the follow-ups! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Packages doesn't seem to expose either
/api/v1/gemsor/versionsendpoints. It instead uses/api/v1/dependenciesto answer queries from bundler.See https://andre.arko.net/2014/03/28/the-new-rubygems-index-format/ for the differences between these APIs.
This PR adds fallback from
/api/v1/gems/*.jsonto/api/v1/dependenciesto support GitHub Packages.It involves parsing Ruby's Marshal format, so I created @qnighy/marshal for the purpose.
Note on marshal: I found a clear bug in
_getLengthand thought I can build better libraries myself. However, when writing this PR, I revisited the code and found_getLengthis used less often (there is a redundant correct implementation elsewhere) and the bug's effect is fairly limited. It turned out to be well-written than I expected. I still think mine can compete and at least have a TypeScript definition wheremarshaldoesn't. Ifmarshalis preferred, I'm willing to rewrite the code to usemarshal.Changes:
When updating RubyGems artifacts and if it uses registries other than
rubygems.org, Renovate used to inquiry/api/v1/gems/*.jsonfor the package info. After this change, it falls back to/api/v1/dependenciesif the former API is not available (returns 404). As a result, Renovate will be able to update dependencies from GitHub Packages RubyGems registry.Context:
Trying to use Renovate with private dependencies in GitHub Packages, but it could not update them.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: