Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix http mocks #11191

Merged
merged 1 commit into from Aug 9, 2021
Merged

test: fix http mocks #11191

merged 1 commit into from Aug 9, 2021

Conversation

viceice
Copy link
Member

@viceice viceice commented Aug 9, 2021

Changes:

  • Auto validate missing http mocks after each test.
  • Add missing http mocks
  • Added FIXME for bigger required changes and unknown behavior

Context:

fixes #11141

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins merged commit 394f0bb into main Aug 9, 2021
@rarkins rarkins deleted the test/nock-mock-fixes branch August 9, 2021 17:37
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.70.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getChangeLogJSON › supports github enterprise test fails intermittently
3 participants