Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gradle): use java image for docker mode #11316

Merged
merged 8 commits into from Aug 19, 2021
Merged

feat(gradle): use java image for docker mode #11316

merged 8 commits into from Aug 19, 2021

Conversation

viceice
Copy link
Member

@viceice viceice commented Aug 18, 2021

Changes:

  • gradle/deep and gradle-wrapper managers are now using java docker image.
  • moved some code to gradle-wrapper because gradle/deep will be removed in future
  • fixed fs usages to use our fs wrapper

Context:

ref #6364

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice
Copy link
Member Author

viceice commented Aug 18, 2021

Will prepare real test repos to check if it works as expected

@viceice
Copy link
Member Author

viceice commented Aug 18, 2021

@rarkins
Copy link
Collaborator

rarkins commented Aug 18, 2021

For "deep" gradle, will it work if no gradlew is present?

@viceice
Copy link
Member Author

viceice commented Aug 18, 2021

For "deep" gradle, will it work if no gradlew is present?

Not yet, will add a precommand to dynamically install gradle if no gradlew is found

@viceice viceice marked this pull request as ready for review August 19, 2021 12:15
@viceice
Copy link
Member Author

viceice commented Aug 19, 2021

Ready for review 🎉

@viceice viceice merged commit ae0ac14 into main Aug 19, 2021
@viceice viceice deleted the feat/dynamic-java branch August 19, 2021 12:44
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 26.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants