fix(datasource/maven): look for maven snapshot pom #11327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maven snapshot poms are stored in the repository with timestamp & build number replacing the -SNAPSHOT in the name. The check for missing artifacts did not resolve these files and so SNAPSHOTS always appeared missing and were filtered out.
|
Hi, is there something I missed on the PR to get it looked at? |
|
I'll go ping some reviewers for you. 😉 |
viceice
reviewed
Aug 27, 2021
Remove test expectations Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
zharinov
suggested changes
Sep 6, 2021
Move more snapshot logic into mockGenericPackage, per code review request Adding snapshots to maven metadata.xml required changes to clojure tests
rarkins
requested changes
Sep 28, 2021
|
Peppered some comments in to the affected logic. |
zharinov
reviewed
Oct 10, 2021
| const queue = versions | ||
| .map((version): [string, url.URL | null] => { | ||
| // For each version, determine if there is a POM file available for it | ||
| const results: ArtifactInfoResult[] = await pMap( |
rarkins
approved these changes
Oct 10, 2021
|
🎉 This PR is included in version 27.31.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maven snapshot poms are stored in the repository with timestamp & build number replacing the -SNAPSHOT in the name.
The check for missing artifacts did not resolve these files and so SNAPSHOTS always appeared missing and were filtered out.
Not sure if the async handling in
filterMissingArtifacts()is the best, please let me know if changes needed.Changes:
Maven snapshot dependencies should now be included without wholesale disabling the pom check via
RENOVATE_EXPERIMENTAL_NO_MAVEN_POM_CHECK.Context:
This should fix issue #3728
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: