fix(datasource): trim trailing slash in registry url

[viceice]

Changes:

• Always trim trailing registry url trailing slash before passing to datasource
• Proper url join for gitlab-tags datasource
• Proper url join for repology datasource

Context:

closes #11254

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[viceice]

Most datasources are already handling trailing slashes, so after this pr we should refactor them, so we know we don't have any trailing slash

[rarkins]

Questions, not suggestions:

Why strip trailing slash and not enforce?

Why manual URL construction using string templates instead of URL.join type of joining?

[viceice]

Why strip trailing slash and not enforce?

🤷‍♂️ Looks cleaner to me when joining via strings, but we can also enforce them if you prefer.

Why manual URL construction using string templates instead of URL.join type of joining?

Url.resolve is deprecated, so needs to be replaced and will do a wrong join at that place.
I don't see much value to have an additional joind method, but we can use url-join if you prefer.

[viceice]

Looks like url-join would do right things here too.

[rarkins]

I'm ok with trimming the slash. Less chance we have duped cache entries. Would prefer we didn't do raw URL concatenation ourselves, or at least centralised it

[viceice]

Ok, will Push the changes later

[aslafy-z]

Any change this gets merged any-time soon? Thank you

[rarkins]

@aslafy-z have you been able to run and verify this branch locally?

[viceice]

DEBUG: packageFiles with updates (repository=aslafy-z/reproduce-renovate-bug-docker-hub)
       "config": {
         "regex": [
           {
             "packageFile": "components.yaml",
             "deps": [
               {
                 "depName": "jettech/kube-webhook-certgen",
                 "currentValue": "v1.5.0",
                 "datasource": "docker",
                 "versioning": "docker",
                 "replaceString": "ok_version: \"v1.5.0\" # renovate: datasource=docker depName=jettech/kube-webhook-certgen versioning=docker\n",
                 "depIndex": 0,
                 "updates": [
                   {
                     "bucket": "patch",
                     "newVersion": "v1.5.2",
                     "newValue": "v1.5.2",
                     "newMajor": 1,
                     "newMinor": 5,
                     "updateType": "patch",
                     "branchName": "renovate-test/jettech-kube-webhook-certgen-1.5.x"
                   }
                 ],
                 "warnings": [],
                 "currentVersion": "v1.5.0",
                 "isSingleVersion": true,
                 "fixedVersion": "v1.5.0"
               },
               {
                 "depName": "jettech/kube-webhook-certgen",
                 "currentValue": "v1.5.1",
                 "datasource": "docker",
                 "versioning": "docker",
                 "registryUrls": ["https://index.docker.io/"],
                 "replaceString": "not_ok_version: \"v1.5.1\" # renovate: datasource=docker depName=jettech/kube-webhook-certgen registryUrl=https://index.docker.io versioning=docker\n",
                 "depIndex": 1,
                 "updates": [
                   {
                     "bucket": "patch",
                     "newVersion": "v1.5.2",
                     "newValue": "v1.5.2",
                     "newMajor": 1,
                     "newMinor": 5,
                     "updateType": "patch",
                     "branchName": "renovate-test/jettech-kube-webhook-certgen-1.5.x"
                   }
                 ],
                 "warnings": [],
                 "currentVersion": "v1.5.1",
                 "isSingleVersion": true,
                 "fixedVersion": "v1.5.1"
               }
             ],
             "matchStrings": [
               "[^\\n]*_version: \"(?<currentValue>.*)\"\\s*#\\s*renovate:\\s*datasource=(?<datasource>.*?) depName=(?<depName>.*?)( registryUrl=(?<registryUrl>.*?))?( versioning=(?<versioning>.*?))?\\n"
             ]
           }
         ]
       }

[viceice]

@rarkins I've run this on some different repos and didn't found any issue. So i'm 95% sure it's save to merge

[renovate-release]

🎉 This PR is included in version 26.13.6 🎉

The release is available on:

• GitHub release
• 26.13.6

Your semantic-release bot 📦🚀