Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kustomize): add components support #11553

Merged
merged 6 commits into from Sep 3, 2021

Conversation

cilindrox
Copy link
Contributor

Changes:

Add suport for kustomize components, which essentially work just
as the resources directive.

Context:

In addition to the deprecated bases and their resources replacement, Kustomize also introduces the concept of components, layers essentially, that can be referenced from higher-level overlays.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

rarkins
rarkins previously approved these changes Sep 3, 2021
viceice
viceice previously approved these changes Sep 3, 2021
@HonkingGoose
Copy link
Collaborator

There's a Jest snapshot problem according to the build-pr action log.

@cilindrox
Copy link
Contributor Author

@HonkingGoose I saw that locally and it prompted I ran the tests via yarn run jest -u (seems to skip the snapshot) - is there anything I can do about it?

@cilindrox cilindrox dismissed stale reviews from viceice and rarkins via b582666 September 3, 2021 11:31
@cilindrox
Copy link
Contributor Author

Pushed updated snapshot - lmk if that works, otherwise I can take it back, and thanks for the reviews!

@viceice viceice enabled auto-merge (squash) September 3, 2021 11:32
@viceice viceice merged commit 3d56684 into renovatebot:main Sep 3, 2021
@cilindrox cilindrox deleted the feat-kustomize-components branch September 3, 2021 11:45
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 26.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants