Docker references in gitlab-ci.yml split on multiple lines is not updated correctly

[martin-sucha]

How are you running Renovate?

Self-hosted

Please select which platform you are using if self-hosting.

GitLab self-hosted

If you're self-hosting Renovate, tell us what version of Renovate you run.

26.19.1

Describe the bug

When the Docker image reference in gitlab-ci.yml file is split into multiple lines in yaml file, renovate does
not update the whole reference, only the part on the first line.

I would expect renovate to either fail with an error because it can't update multiline references or update the whole reference (does not need to stay split on multiple lines).

Relevant debug logs

Logs

INFO: Repository started (repository=search-team/gonuts/conveyance-store)
       "renovateVersion": "26.19.1"
 INFO: Dependency extraction complete (repository=search-team/gonuts/conveyance-store)
       "baseBranch": "master",
       "stats": {
         "managers": {
           "docker-compose": {"fileCount": 6, "depCount": 7},
           "dockerfile": {"fileCount": 18, "depCount": 20},
           "gitlabci": {"fileCount": 7, "depCount": 20},
           "gomod": {"fileCount": 2, "depCount": 55},
           "pre-commit": {"fileCount": 1, "depCount": 3}
         },
         "total": {"fileCount": 34, "depCount": 105}
       }
 INFO: Ignoring upgrade collision (repository=search-team/gonuts/conveyance-store, packageFile=.gitlab/ci/test.yml, branch=renovate/all)
       "manager": "gitlabci",
       "depName": "scylladb/scylla-enterprise",
       "currentValue": "2021.1.2",
       "previousNewValue": "2021.1.5",
       "thisNewValue": "2021.1.2"
 INFO: Ignoring upgrade collision (repository=search-team/gonuts/conveyance-store, packageFile=.gitlab/ci/test.yml, branch=renovate/all)
       "manager": "gitlabci",
       "depName": "scylladb/scylla-enterprise",
       "currentValue": "2021.1.2",
       "previousNewValue": "2021.1.5",
       "thisNewValue": "2021.1.2"
 INFO: Ignoring upgrade collision (repository=search-team/gonuts/conveyance-store, packageFile=.gitlab/ci/lint.yml, branch=renovate/all)
       "manager": "gitlabci",
       "depName": "renovate/renovate",
       "currentValue": "25.64-slim",
       "previousNewValue": "26.19-slim",
       "thisNewValue": "25.64-slim"
 INFO: Repository finished (repository=search-team/gonuts/conveyance-store)
       "durationMs": 143437

Have you created a minimal reproduction repository?

No reproduction repository

[github-actions]

Hi there,

Help us by making a minimal reproduction repository.

Before we can start work on your issue we first need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction to understand what is needed.

We may close the issue if you (or someone else) have not provided a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

[martin-sucha]

I've created a reproducer repo: https://github.com/kiwicom/renovate-11595

[viceice]

This looks pretty weird, is this supported by gitlab / yaml ?

[martin-sucha]

Gitlab just parses yaml.

Splitting a string to multiple lines is a standard feature of yaml:

In a multi-line double-quoted scalar, line breaks are are subject to flow line folding, which discards any trailing white space characters. It is also possible to escape the line break character. In this case, the line break is excluded from the content, and the trailing white space characters are preserved. Combined with the ability to escape white space characters, this allows double-quoted lines to be broken at arbitrary positions.

Some examples are also at https://yaml-multiline.info/

So in

  services:
    - name: "alpine:3.12.8@\
              sha256:a296b4c6f6ee2b88f095b61e95c7ef4f51ba25598835b4978c9256d8c8ace48a"

the value for name key parses as alpine:3.12.8@sha256:a296b4c6f6ee2b88f095b61e95c7ef4f51ba25598835b4978c9256d8c8ace48a

We had the image reference split to multiple lines because of the line length. Obviously we worked around the issue by putting the image reference entirely on a single line. However, I wonder how renovate updates the yaml file as it had not replaced whole value for image key in the yaml, but has replaced the \ at the end of the line and I would have expected renovate to replace the entire yaml string.

[viceice]

Ok, this will be very tricky to fix.

• If we parse the file as yaml, we get right value, but string replace fails.
• Parse with regex is difficult too, as the line break can be at arbitrary position.

I've an idea and will experiment a little.