Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pip_setup): Add JavaScript-based implementation #11796

Merged
merged 30 commits into from Nov 10, 2021

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Sep 17, 2021

Changes:

Use @renovate/parser-utils for more lightweight manager implementation.

Context:

Closes #10090

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov marked this pull request as ready for review September 27, 2021 13:47
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs documentation and also can we switch to using re2 for regex to avoid any catastrophic failures?

package.json Outdated Show resolved Hide resolved
lib/manager/pip_setup/extract.ts Show resolved Hide resolved
lib/manager/pip_setup/extract.ts Show resolved Hide resolved
lib/manager/pip_setup/extract.ts Show resolved Hide resolved
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use RE2 for regexp if possible. 😉

lib/manager/pip_setup/extract.ts Show resolved Hide resolved
lib/manager/pip_setup/extract.ts Outdated Show resolved Hide resolved
@rarkins rarkins marked this pull request as draft October 11, 2021 07:41
@zharinov zharinov marked this pull request as ready for review November 4, 2021 05:19
@zharinov
Copy link
Collaborator Author

zharinov commented Nov 4, 2021

I think it's good enough for initial release

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump external dep to v1.0.0 first

@zharinov
Copy link
Collaborator Author

zharinov commented Nov 4, 2021

We're planning to release this library as a separate entity, which I aim to develop and support on my own.  I'd prefer to bump it to '0.1.0' instead, and then upgrade to 0.2.x, 0.3.x, and so on until it appears to be suitable for general use. Though, Renovate will benefit from its earlier versions.

@rarkins
Copy link
Collaborator

rarkins commented Nov 5, 2021

@zharinov I thought about it more, and I still want the parser utils to be 1.0.0, which represents production-ready. It doesn't matter to me if you end up getting to v10 or whatever quickly - major releases should be unemotional

Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump dep to 1.0.0

@zharinov
Copy link
Collaborator Author

zharinov commented Nov 7, 2021

Works good with real repo

@rarkins rarkins merged commit 3f585ec into renovatebot:main Nov 10, 2021
@rarkins rarkins deleted the feat/pip-setup-js-based branch November 10, 2021 11:20
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 29.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace pip_requirements python parsing with JS approach
4 participants