New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pip_setup): Add JavaScript-based implementation #11796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs documentation and also can we switch to using re2 for regex to avoid any catastrophic failures?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use RE2 for regexp if possible. 😉
I think it's good enough for initial release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump external dep to v1.0.0 first
We're planning to release this library as a separate entity, which I aim to develop and support on my own. I'd prefer to bump it to '0.1.0' instead, and then upgrade to |
@zharinov I thought about it more, and I still want the parser utils to be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump dep to 1.0.0
Works good with real repo |
🎉 This PR is included in version 29.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
Use
@renovate/parser-utils
for more lightweight manager implementation.Context:
Closes #10090
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: