Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce required access level for dry-run #12036

Closed
fgreinacher opened this issue Oct 6, 2021 · 2 comments · Fixed by #12189
Closed

Reduce required access level for dry-run #12036

fgreinacher opened this issue Oct 6, 2021 · 2 comments · Fixed by #12189
Labels
priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)

Comments

@fgreinacher
Copy link
Contributor

What would you like Renovate to be able to do?

We are pretty stringent about following the principle of least privileges in our development environment. We therefore tried to reduce the GitLab role of the user performing Renovate dry runs from Developer to Reporter which should be no problem for read-only operations.

Now we noticed that this causes Renovate to not find any projects (we're using autodiscovery with filters) and pin-pointed this to the project query at https://github.com/renovatebot/renovate/blob/main/lib/platform/gitlab/index.ts#L138 where only projects with access level 30 (for Developer) and above are retrieved.

If you have any ideas on how this should be implemented, please tell us here.

Do you think it would make sense to reduce this level to 20 (Reporter) when Renovate performs a dry-run?

Is this a feature you are interested in implementing yourself?

Yes
@fgreinacher fgreinacher added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality) labels Oct 6, 2021
@rarkins
Copy link
Collaborator

rarkins commented Oct 7, 2021

Sounds good!

@rarkins rarkins added priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:ready and removed priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started labels Oct 7, 2021
This was referenced Oct 13, 2021
Closed
Merged
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 28.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)
Projects
None yet
Milestone
No milestone
3 participants
@fgreinacher @rarkins @renovate-release