Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): improve descriptions for default presets #12073

Conversation

HonkingGoose
Copy link
Collaborator

@HonkingGoose HonkingGoose commented Oct 8, 2021

Changes:

  • Capitalize proper noun Git
  • Capitalize proper noun Docker
  • Capitalize proper noun Renovate
  • Change semver -> SemVer
  • Add some <code></code> blocks to improve ease of reading
  • Improve descriptions for prConcurrentLimitNone and prConcurrentLimit10

Context:

Fixing up some descriptions.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice previously approved these changes Oct 8, 2021
@HonkingGoose
Copy link
Collaborator Author

Is there a good way to limit the yarn jest -u command to just the files that I'm changing?

@viceice
Copy link
Member

viceice commented Oct 8, 2021

Sure, put partial path behind, eg yarn jest -u lib/config/presets/

@HonkingGoose
Copy link
Collaborator Author

Sure, put partial path behind, eg yarn jest -u lib/config/presets/

Cool! I'll go try that next time. The yarn jest -u finished running anyways. 😄 I've also manually updated a test file.

@viceice viceice requested a review from rarkins October 8, 2021 12:16
@rarkins rarkins enabled auto-merge (squash) October 10, 2021 19:30
@rarkins rarkins merged commit e5ccf2b into renovatebot:main Oct 10, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 27.31.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

@HonkingGoose HonkingGoose deleted the fix/improve-descriptions-for-default-presets branch October 10, 2021 19:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants