New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(manager/npm): invalid link in git hash updates for npm #12111
fix(manager/npm): invalid link in git hash updates for npm #12111
Conversation
|
But using |
Hi @rarkins I removed the link for |
@olegkrivtsov can you test it on a real repo, showing both digest and non-digest updates? |
@rarkins I've done that on https://github.com/olegkrivtsov/renovate-npm-bug. You can see that Renovate created two PRs - one for digest, and one for non-digest. |
🎉 This PR is included in version 28.0.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
Work in progress. I'd like to push my current changes to request some feedback/advice.
I'm currently in doubt. I've modified
prBodyDefinitions
and the link is now overridden when theupdateType
isdigest
. But, it is not clear:platform
variable which is consumed by Handlebars equals totogithub
. It is weird, not sure why it looks like this. In my test, my link points tohttps://togithub.com/olegkrivtsov/renovate-npm-bug/compare/9e3dc07...489cbc7
, so the domain name is incorrect. What variable should I use to get the correct platform name?Context:
Closes: #6224
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: