Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(regex): allow to capture groups at each recursion #12286

Merged
merged 7 commits into from Oct 31, 2021

Conversation

scrocquesel
Copy link
Contributor

Changes:

This will allow to capture groups and merge them recursively with the recursive match string strategy.

Context:

Closes #12279

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from secustor October 28, 2021 09:33
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
lib/manager/regex/index.ts Outdated Show resolved Hide resolved
lib/manager/regex/index.ts Outdated Show resolved Hide resolved
lib/manager/regex/index.spec.ts Outdated Show resolved Hide resolved
@secustor
Copy link
Collaborator

Some small changes and the test is failing

@rarkins rarkins marked this pull request as draft October 28, 2021 14:47
@rarkins rarkins marked this pull request as ready for review October 29, 2021 10:42
@rarkins rarkins enabled auto-merge (squash) October 31, 2021 06:38
@rarkins rarkins merged commit 18ea9c9 into renovatebot:main Oct 31, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 28.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@scrocquesel scrocquesel deleted the gh-12279 branch November 2, 2021 18:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support intermediate captured groups in recursive strategy
4 participants