feat(manager/regex)!: allow arbitrary regex groups for templates

[secustor]

Changes:

This PR allows the usage of arbitrary capture groups inside of regex manager templates and further adds refactor which this allows.

BREAKING_CHANGE
Only regex managers using the combination matchStringStrategy are affected of this change!
Currently capture groups which are empty but still match the regex are ignored.
This is no longer the case!
Subsequent matchGroups will now overwrite previous ones, even if the later one is empty.

Context:

Fixes #11387

Related: #12279

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[rarkins]

@secustor could you write the BREAKING CHANGE description a little clearer? We'll issue a new major release in the next few working days once GOPROXY changes are ready

[rarkins]

@secustor can you resolve the merge conflict?

[secustor]

@rarkins Done.

[rarkins]

Is it possible to separate out the refactor from the breaking change? It's currently pretty hard to review due to the file changes.

[secustor]

I have reverted the addition of an utils.ts, which should make the changes clearer.

But I'm not sure what is missing for codecov. In my overview there is no reference to the offending lines

[viceice]

I have reverted the addition of an utils.ts, which should make the changes clearer.

The idea was to open a new pr with just the refactoring, so we can merge that before this.

But I'm not sure what is missing for codecov. In my overview there is no reference to the offending lines

I think this is only a codecov issue, as there are no coverage changes. 🤷‍♂️

[viceice]

Do we need to change our own regex managers or will they work as before?

Looks good so far

[secustor]

I have reverted the addition of an utils.ts, which should make the changes clearer.

The idea was to open a new pr with just the refactoring, so we can merge that before this.

But I'm not sure what is missing for codecov. In my overview there is no reference to the offending lines

I think this is only a codecov issue, as there are no coverage changes. man_shrugging

I thought it would be easier to create a PR for this when the changes are released than vice versa.

If you are referring to https://github.com/renovatebot/.github/blob/main/default.json, then no changes are necessary as this only affects regex managers with matchStringStrategy combination.

The base branch was changed.