Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of yarnrc config override breaks usability #12321

Closed
dschaller opened this issue Oct 25, 2021 · 7 comments
Closed

Removal of yarnrc config override breaks usability #12321

dschaller opened this issue Oct 25, 2021 · 7 comments
Labels
manager:npm package.json files (npm/yarn/pnpm) status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality

Comments

@dschaller
Copy link
Contributor

How are you running Renovate?

WhiteSource Renovate hosted app on github.com

Please select which platform you are using if self-hosting.

No response

If you're self-hosting Renovate, tell us what version of Renovate you run.

No response

Describe the bug

#10114 removed the ability to specify a yarnrc override from within the renovate config. However, this means that repositories that rely on yarn-path in their yarnrc file cannot run properly. Is there a way to run a pre-upgrade script to install the required binary into the specified location?

For an example use case see github.com/lyft/clutch

Relevant debug logs

Logs
Copy/paste any log here, between the starting and ending backticks

Have you created a minimal reproduction repository?

No reproduction, but I have linked to a public repo where it occurs

@dschaller dschaller added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality labels Oct 25, 2021
@viceice viceice added auto:reproduction A minimal reproduction is necessary to proceed manager:npm package.json files (npm/yarn/pnpm) labels Oct 25, 2021
@github-actions
Copy link
Contributor

Hi there,

Help us by making a minimal reproduction repository.

Before we can start work on your issue we first need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction to understand what is needed.

We may close the issue if you (or someone else) have not provided a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

@dschaller
Copy link
Contributor Author

@HonkingGoose HonkingGoose added reproduction:provided and removed auto:reproduction A minimal reproduction is necessary to proceed labels Oct 25, 2021
@rarkins
Copy link
Collaborator

rarkins commented Oct 26, 2021

However, this means that repositories that rely on yarn-path in their yarnrc file cannot run properly.

I don't think this is correct, because we have many projects working this way. It's only a problem if you specify a path in your repo which doesn't exist. Doesn't Yarn recommend committing this file and is there a reason why you can't?

@dschaller
Copy link
Contributor Author

Ah apologies @rarkins, my statement was only true in context of projects that specify a path to a file that doesn't always exist. In the example repository provided the binary is downloaded but not included to be tracked in git. Yarn does recommend bundling the binary but there are projects that do not include it.

Just figured I would ask again, is there a way to run a pre-upgrade script to install the required binary into the specified location?

@rarkins
Copy link
Collaborator

rarkins commented Oct 26, 2021

There is currently not a way. If you want to submit a PR which simply deletes unreachable yarn paths before calling Yarn, then that would be an OK workaround for us.

FWIW the yarn documentation says "Useful if you want to bundle Yarn into your repository and have everyone use the same version for consistency." which I think implies it should be committed into your repo.

@dschaller
Copy link
Contributor Author

ok thanks for the suggestion.

Yeah, the docs seem to imply that it should be bundled in some manner. I think it's just that our interpretation of "bundle" is to include a way to get the binary instead of the binary itself :)

@viceice
Copy link
Member

viceice commented Oct 26, 2021

There is an open issue about pre upgrade tasks, those will only work in self-hosted renovate.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:npm package.json files (npm/yarn/pnpm) status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality
Projects
None yet
Development

No branches or pull requests

4 participants