Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kustomize): Support Component kustomizations #12467

Merged
merged 8 commits into from Nov 4, 2021
Merged

feat(kustomize): Support Component kustomizations #12467

merged 8 commits into from Nov 4, 2021

Conversation

maxbrunet
Copy link
Contributor

Changes:

Add support for Component kustomizations:
https://kubectl.docs.kubernetes.io/guides/config_management/components/

Context:

Components, while behaving differently from Kustomizations, have a content nearly identical to them, thus dependencies can be updated in the same fashion.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@maxbrunet
Copy link
Contributor Author

It is not clear to me why the test fails, it passes toMatchSnapshot(), but it does not have the 1st dependency which is in the snapshot 😕

@rarkins rarkins marked this pull request as draft November 3, 2021 05:41
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs test fixing. Snapshots can be updated using yarn jest kustomize -u but make sure to verify that the updates are as expected before committing.

Also desirable to add the depType field

lib/manager/kustomize/extract.ts Show resolved Hide resolved
@rarkins rarkins marked this pull request as ready for review November 4, 2021 08:10
@rarkins rarkins enabled auto-merge (squash) November 4, 2021 08:10
@rarkins rarkins merged commit f075ffc into renovatebot:main Nov 4, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 28.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2021
@maxbrunet maxbrunet deleted the feat/kustomize/components branch July 20, 2022 18:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants