Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(github): Extract getSourceUrl function #12510

Merged
merged 2 commits into from Nov 5, 2021

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Nov 5, 2021

Changes:

Generate source URL directly without any release fetching

Context:

Ref: #12486

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins
Copy link
Collaborator

rarkins commented Nov 5, 2021

Please sanity check it on a real repo first, or let me know if you think the unit tests are solid enough to be sure

@zharinov zharinov marked this pull request as draft November 5, 2021 09:46
@zharinov zharinov marked this pull request as ready for review November 5, 2021 10:09
@zharinov
Copy link
Collaborator Author

zharinov commented Nov 5, 2021

Works fine

@rarkins rarkins enabled auto-merge (squash) November 5, 2021 10:25
@rarkins rarkins merged commit 3cd70f8 into renovatebot:main Nov 5, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 29.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants