Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/kustomize): support HelmChartInflationGenerator #12628

Merged
merged 18 commits into from Nov 17, 2021

Conversation

andrein
Copy link
Contributor

@andrein andrein commented Nov 12, 2021

Changes:

This PR adds support for renovating helm charts used in kustomize

Context:

Closes #6155

Documentation (please check one with an [x])

Docs are missing, I'd like to get some feedback on the implementation first.

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@andrein andrein changed the title Feat/kustomize helm feat: Kustomize HelmChartInflationGenerator support Nov 12, 2021
@viceice viceice self-requested a review November 12, 2021 23:52
lib/manager/kustomize/types.ts Outdated Show resolved Hide resolved
lib/manager/kustomize/extract.ts Outdated Show resolved Hide resolved
lib/manager/kustomize/extract.ts Outdated Show resolved Hide resolved
lib/manager/kustomize/extract.spec.ts Outdated Show resolved Hide resolved
@viceice viceice added the manager:kustomize Kustomize manager label Nov 13, 2021
@viceice viceice changed the title feat: Kustomize HelmChartInflationGenerator support feat(manager/kustomize): support HelmChartInflationGenerator Nov 13, 2021
@andrein andrein requested a review from viceice November 13, 2021 18:37
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@andrein
Copy link
Contributor Author

andrein commented Nov 13, 2021

Ok, I'll fix the test. Can we leave the fields in the Kustomize interface as they are, and I'll follow up with another PR to make all of them optional?

@andrein andrein requested a review from viceice November 13, 2021 20:22
rarkins
rarkins previously approved these changes Nov 17, 2021
viceice
viceice previously approved these changes Nov 17, 2021
lib/manager/kustomize/readme.md Outdated Show resolved Hide resolved
@andrein andrein dismissed stale reviews from viceice and rarkins via 0c7285a November 17, 2021 09:10
@andrein andrein requested a review from viceice November 17, 2021 10:12
@andrein andrein requested a review from rarkins November 17, 2021 10:12
@rarkins rarkins enabled auto-merge (squash) November 17, 2021 14:16
@rarkins rarkins merged commit 8184bda into renovatebot:main Nov 17, 2021
@andrein andrein deleted the feat/kustomize-helm branch November 17, 2021 15:04
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 29.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:kustomize Kustomize manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: ChartInflator kustomize plugin support
4 participants