New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager/kustomize): support HelmChartInflationGenerator #12628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrein
changed the title
Feat/kustomize helm
feat: Kustomize HelmChartInflationGenerator support
Nov 12, 2021
viceice
requested changes
Nov 13, 2021
viceice
changed the title
feat: Kustomize HelmChartInflationGenerator support
feat(manager/kustomize): support HelmChartInflationGenerator
Nov 13, 2021
viceice
reviewed
Nov 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
Ok, I'll fix the test. Can we leave the fields in the Kustomize interface as they are, and I'll follow up with another PR to make all of them optional? |
6 tasks
rarkins
previously approved these changes
Nov 17, 2021
viceice
previously approved these changes
Nov 17, 2021
viceice
approved these changes
Nov 17, 2021
🎉 This PR is included in version 29.11.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR adds support for renovating helm charts used in kustomize
Context:
Closes #6155
Documentation (please check one with an [x])
Docs are missing, I'd like to get some feedback on the implementation first.
How I've tested my work (please tick one)
I have verified these changes via: