Go modules digest update is not working

[at-wat]

How are you running Renovate?

WhiteSource Renovate hosted app on github.com

If you're self-hosting Renovate, tell us what version of Renovate you run.

No response

Please select which platform you are using if self-hosting.

No response

If you're self-hosting Renovate, tell us what version of the platform you run.

No response

Describe the bug

Existing Go modules update PRs referring commit digest are closed on Oct 27 and no longer created.

Reproduction: at-wat/renovate-repro-gomod-digest#1
Current version of golang.org/x/net is v0.0.0-20210825183410-e898025ed96a and latest version is v0.0.0-20211112202133-69e39bad7dc2 (golang/net@69e39ba), but treated as no update.

On my private sandbox repo, unmerged PR seems be closed at 2021-10-27T17:48:50Z (18 days ago).

Relevant debug logs

Logs

DEBUG: Matched 1 file(s) for manager gomod: go.mod
DEBUG: Found gomod package files
DEBUG: Found 1 package file(s)
INFO: Dependency extraction complete
{
  "baseBranch": "master",
  "stats": {
    "managers": {
      "gomod": {
        "fileCount": 1,
        "depCount": 3
      }
    },
    "total": {
      "fileCount": 1,
      "depCount": 3
    }
  }
}
DEBUG: Found no results from datasource that look like a version (golang.org/x/net)(dependency="golang.org/x/net")
{
  "result": {
    "sourceUrl": "https://github.com/golang/net",
    "releases": []
  }
}
DEBUG: Found no results from datasource that look like a version (github.com/seqsense/pcgol)(dependency="github.com/seqsense/pcgol")
{
  "result": {
    "sourceUrl": "https://github.com/seqsense/pcgol",
    "releases": []
  }
}
DEBUG: Found no results from datasource that look like a version (github.com/at-wat/renovate-repro-gomod-dummy)(dependency="github.com/at-wat/renovate-repro-gomod-dummy")
{
  "result": {
    "sourceUrl": "https://github.com/at-wat/renovate-repro-gomod-dummy",
    "releases": []
  }
}
DEBUG: Package releases lookups complete
{
  "baseBranch": "master"
}
DEBUG: branchifyUpgrades
DEBUG: 0 flattened updates found:
DEBUG: Returning 0 branch(es)
DEBUG: config.repoIsOnboarded=true
DEBUG: packageFiles with updates
{
  "config": {
    "gomod": [
      {
        "packageFile": "go.mod",
        "constraints": {
          "go": "^1.17"
        },
        "deps": [
          {
            "managerData": {
              "lineNumber": 4
            },
            "depName": "golang.org/x/net",
            "depType": "require",
            "currentValue": "v0.0.0-20210825183410-e898025ed96a",
            "datasource": "go",
            "currentDigest": "e898025ed96a",
            "digestOneAndOnly": true,
            "depIndex": 0,
            "updates": [],
            "warnings": [],
            "versioning": "semver",
            "sourceUrl": "https://github.com/golang/net",
            "currentVersion": "v0.0.0-20210825183410-e898025ed96a",
            "fixedVersion": "v0.0.0-20210825183410-e898025ed96a"
          },
          {
            "managerData": {
              "lineNumber": 7,
              "multiLine": true
            },
            "depName": "github.com/at-wat/renovate-repro-gomod-dummy",
            "depType": "require",
            "currentValue": "v0.0.0-20211025070218-857fe7d90bf1",
            "datasource": "go",
            "currentDigest": "857fe7d90bf1",
            "digestOneAndOnly": true,
            "depIndex": 1,
            "updates": [],
            "warnings": [],
            "versioning": "semver",
            "sourceUrl": "https://github.com/at-wat/renovate-repro-gomod-dummy",
            "currentVersion": "v0.0.0-20211025070218-857fe7d90bf1",
            "fixedVersion": "v0.0.0-20211025070218-857fe7d90bf1"
          },
          {
            "managerData": {
              "lineNumber": 8,
              "multiLine": true
            },
            "depName": "github.com/seqsense/pcgol",
            "depType": "require",
            "currentValue": "v0.0.0-20211020051623-80c7a95f592a",
            "datasource": "go",
            "currentDigest": "80c7a95f592a",
            "digestOneAndOnly": true,
            "depIndex": 2,
            "updates": [],
            "warnings": [],
            "versioning": "semver",
            "sourceUrl": "https://github.com/seqsense/pcgol",
            "currentVersion": "v0.0.0-20211020051623-80c7a95f592a",
            "fixedVersion": "v0.0.0-20211020051623-80c7a95f592a"
          }
        ]
      }
    ]
  }
}

Have you created a minimal reproduction repository?

I have linked to a minimal reproduction repository in the bug description

[github-actions]

Hi there,

Help us by making a minimal reproduction repository.

Before we can start work on your issue we first need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction to understand what is needed.

We may close the issue if you (or someone else) have not provided a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

[rarkins]

The hosted app switched to using the default golang proxy and it means that not every git commit triggers a new valid digest update. Previously Renovate was probably too eager to update digests

[at-wat]

In the reproduction repo I posted, current version of golang.org/x/net is on Aug 26 and the oldest update after the current version is on Sep 3.

There are tens of newer versions which must be on the default golang proxy.

[rarkins]

I can confirm that in a new go modules I run go get -u golang.org/x/net and get a result of v0.0.0-20211112202133-69e39bad7dc2. Also see it in the list here: https://pkg.go.dev/golang.org/x/net?tab=versions

Next things to check are:

1. Are we getting a value through the go proxy?
2. If not, should we get it through the proxy?
3. If we shouldn't get it through the proxy, then are we correctly fetching it direct?

Cc @zharinov

[at-wat]

If there is a staging instance of renovate server, connecting staging renovate to some repositories which always have dependencies not yet updated would help finding this kind of problems, I guess.

[renovate-release]

🎉 This issue has been resolved in version 29.8.3 🎉

The release is available on:

• GitHub release
• 29.8.3

Your semantic-release bot 📦🚀

[at-wat]

Confirmed that PRs updating digest are back on reproduction repo.
Thank you for the speedy fix.