Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(jenkins-plugins): convert to class-based datasource #12702

Merged
merged 6 commits into from Nov 18, 2021

Conversation

JamieMagee
Copy link
Contributor

Changes:

  • Converts jenkins-plugins datasource to be class-based
  • Switches to using Renovate's standard caching instead of custom internal caching

Context:

#8647

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@JamieMagee
Copy link
Contributor Author

I will create and run this on a test repo before merging.

rarkins
rarkins previously approved these changes Nov 17, 2021
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tested

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some small things 🙃

lib/datasource/index.ts Outdated Show resolved Hide resolved
lib/datasource/jenkins-plugins/index.spec.ts Outdated Show resolved Hide resolved
lib/datasource/jenkins-plugins/index.ts Outdated Show resolved Hide resolved
@JamieMagee
Copy link
Contributor Author

Run on https://github.com/renovate-reproductions/12702. Created 4 PRs:

Only made 2 requests to Jenkins API

"hostStats": {
  "api.github.com": {"requestCount": 26, "requestAvgMs": 213, "queueAvgMs": 0},
  "updates.jenkins.io": {
    "requestCount": 2,
    "requestAvgMs": 3688,
    "queueAvgMs": 1
  }
}

Followup run made 0 requests to Jenkins API (AKA only used cache)

"hostStats": {"api.github.com": {"requestCount": 17, "requestAvgMs": 451, "queueAvgMs": 0}}

@JamieMagee JamieMagee enabled auto-merge (squash) November 18, 2021 19:46
@JamieMagee JamieMagee merged commit 789caad into main Nov 18, 2021
@JamieMagee JamieMagee deleted the refactor/jenkins-datasource branch November 18, 2021 19:55
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 29.13.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants