Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: global config #12743

Merged
merged 8 commits into from Nov 23, 2021
Merged

refactor: global config #12743

merged 8 commits into from Nov 23, 2021

Conversation

pret-a-porter
Copy link
Contributor

Changes:

Refactored global config

Context:

#12639

Documentation

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@JamieMagee
Copy link
Contributor

Can you run on a real repo please? To confirm end-to-end flow. Apart from that, this looks good to go!

@pret-a-porter
Copy link
Contributor Author

Can you run on a real repo please? To confirm end-to-end flow. Apart from that, this looks good to go!

Sure. Shall I configure it some certain way?

viceice
viceice reviewed Nov 22, 2021
View reviewed changes
lib/config/global.ts Outdated Show resolved Hide resolved
lib/config/global.ts Show resolved Hide resolved
@pret-a-porter
Copy link
Contributor Author

Yeah, typescript will only use first two decalrations for caller type check and the last for local type check

Done https://github.com/pret-a-porter-testing/renovate-reproduction-12639

viceice
viceice reviewed Nov 23, 2021
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some more changes because of main merge 😉

@viceice viceice merged commit 06d8c27 into renovatebot:main Nov 23, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 29.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2021
@pret-a-porter pret-a-porter deleted the refactor/global_config branch January 11, 2022 20:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@JamieMagee JamieMagee Awaiting requested review from JamieMagee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pret-a-porter @JamieMagee @renovate-release @viceice