fix(azure): correctly map autoApprove response #12761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkimmich-onventis
changed the title
viceice
reviewed
Nov 19, 2021
viceice
reviewed
Nov 20, 2021
|
Good catch! How did TypeScript not warn on this? It looks like we have an update for the Azure DevOps API too! |
viceice
approved these changes
Nov 21, 2021
|
🎉 This PR is included in version 29.14.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Currently there is a type mismatch when autoApproving a pull request in Azure. When adding a reviewer with the Azure API, the response type is
IdentityRefWithVote, see here. However, theprvariable which should have typeGitPullRequestis overriden with the response, which leads to the PR information getting lost.Context:
Closes #12303
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: