-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(logger): Update logger internals #12842
Merged
viceice
merged 10 commits into
renovatebot:main
from
zharinov:refactor/logger-directory
Nov 27, 2021
Merged
refactor(logger): Update logger internals #12842
viceice
merged 10 commits into
renovatebot:main
from
zharinov:refactor/logger-directory
Nov 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zharinov
commented
Nov 25, 2021
We may want to split changes, though maybe it's okay to merge this one |
viceice
reviewed
Nov 25, 2021
This was referenced Nov 26, 2021
6 tasks
6 tasks
6 tasks
6 tasks
viceice
approved these changes
Nov 27, 2021
🎉 This PR is included in version 29.27.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
shortid
tonano-id
Context:
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: