Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(git): Extract types to separate file #12855

Merged
merged 10 commits into from Nov 26, 2021

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Nov 26, 2021

Changes:

  • Extract interfaces to types.ts
  • Update depending imports
  • Change GitNoVerifyOption type to 'push' | 'commit' union

Context:

  • Ref: #7154

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov
Copy link
Collaborator Author

Blocks #12842

rarkins
rarkins previously approved these changes Nov 26, 2021
lib/util/git/index.ts Outdated Show resolved Hide resolved
lib/util/git/index.ts Outdated Show resolved Hide resolved
lib/util/git/index.ts Show resolved Hide resolved
lib/util/git/types.ts Outdated Show resolved Hide resolved
lib/workers/branch/index.spec.ts Outdated Show resolved Hide resolved
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
zharinov and others added 6 commits November 26, 2021 18:52
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@rarkins rarkins enabled auto-merge (squash) November 26, 2021 20:30
@rarkins rarkins merged commit 1a39195 into renovatebot:main Nov 26, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 29.25.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants