-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cache/package): Enable strict checks #12862
Merged
rarkins
merged 7 commits into
renovatebot:main
from
zharinov:refactor/package-cache-strict-nulls
Nov 27, 2021
Merged
refactor(cache/package): Enable strict checks #12862
rarkins
merged 7 commits into
renovatebot:main
from
zharinov:refactor/package-cache-strict-nulls
Nov 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inov/renovate into refactor/package-cache-strict-nulls
rarkins
approved these changes
Nov 27, 2021
if (!client) { | ||
return undefined; | ||
} | ||
logger.trace(`cache.get(${namespace}, ${key})`); | ||
try { | ||
const res = await client?.get(getKey(namespace, key)); | ||
const cachedValue = JSON.parse(res); | ||
const cachedValue = res && JSON.parse(res); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another possible coding mistake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, can throw
viceice
approved these changes
Nov 27, 2021
🎉 This PR is included in version 29.27.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
async/await
if neededContext:
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: