Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(versioning/nuget): sort numerically #13056

Merged
merged 2 commits into from Dec 11, 2021
Merged

fix(versioning/nuget): sort numerically #13056

merged 2 commits into from Dec 11, 2021

Conversation

viceice
Copy link
Member

@viceice viceice commented Dec 11, 2021 •
edited

Changes:

  • try to use semver v2 to compare and fallback to legacy compare
  • use prerelease instead of suffix, simplifies code as it can reuse base code.

Context:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested a review from rarkins December 11, 2021 08:42
rarkins
rarkins previously approved these changes Dec 11, 2021
View reviewed changes
@viceice viceice marked this pull request as draft December 11, 2021 08:59
@viceice viceice requested a review from rarkins December 11, 2021 13:15
@viceice viceice marked this pull request as ready for review December 11, 2021 13:15
@viceice viceice mentioned this pull request Dec 11, 2021
Closed
5 tasks
@viceice viceice merged commit c7dbbd8 into main Dec 11, 2021
@viceice viceice deleted the fix/nuget-versioning-compare branch December 11, 2021 13:37
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 30.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Renovate downgrades nuget preview version.
3 participants
@viceice @renovate-release @rarkins