Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(versioning/nuget): simplify by using class #13059

Merged
merged 2 commits into from Dec 11, 2021
Merged

refactor(versioning/nuget): simplify by using class #13059

merged 2 commits into from Dec 11, 2021

Conversation

viceice
Copy link
Member

@viceice viceice commented Dec 11, 2021

Changes:

  • Use class based generic versioning
  • deprecate old non-class based versioning

Context:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice enabled auto-merge (squash) December 11, 2021 17:06
JamieMagee
JamieMagee approved these changes Dec 11, 2021
View reviewed changes
Copy link
Contributor

@JamieMagee JamieMagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, classes for everything!

@viceice viceice merged commit c96637b into main Dec 11, 2021
@viceice viceice deleted the refactor/nuget-versioning branch December 11, 2021 17:16
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 30.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@viceice viceice mentioned this pull request Jan 4, 2022
Closed
5 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamieMagee JamieMagee JamieMagee approved these changes

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@viceice @renovate-release @JamieMagee @rarkins