Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(util/emoji): Update emoji-related deps #13122

Merged
merged 4 commits into from Dec 15, 2021

Conversation

zharinov
Copy link
Collaborator

Changes:

  • Update relevant deps
  • Remove unused @types/node-emoji
  • Fix unsupported emoji test

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov changed the title Remove unused dep chore(util/emoji): Update emoji-related deps Dec 15, 2021
@rarkins
Copy link
Collaborator

rarkins commented Dec 15, 2021

Conflicts!

package.json Outdated
"emoji-regex": "9.2.2",
"emojibase": "5.2.0",
"emojibase-regex": "5.1.3",
"emoji-regex": "1.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about the downgrade from v9 to v1 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gosh 🤦‍♂️ Thank you

@viceice viceice changed the title chore(util/emoji): Update emoji-related deps fix(util/emoji): Update emoji-related deps Dec 15, 2021
@viceice viceice merged commit d0d4821 into renovatebot:main Dec 15, 2021
@viceice
Copy link
Member

viceice commented Dec 15, 2021

Maybe we should group those in future?

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 31.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants