feat(autodiscover): allow usage of regex patterns

[secustor]

Changes:

Allow to use regex for autodiscoverFilter.

Context:

Discussion: #13168 (comment)
Part of #8763

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[rarkins]

Can we validate the regex too?

[secustor]

The regex is validated implicitly in https://github.com/renovatebot/renovate/blob/main/lib/util/regex.ts#L35

[rarkins]

What's the CLI output look like if it's invalid regex?

[secustor]

There are no explicit lines in that case, as Renovate tries to parse it with minimatch

--autodiscover-filter="/secustor/renovate.**/"

DEBUG: Adding token authentication for api.github.com to hostRules
DEBUG: Using baseDir: /tmp/renovate
DEBUG: Using cacheDir: /tmp/renovate/cache
DEBUG: Initializing Renovate internal cache into /tmp/renovate/cache/renovate/renovate-cache-v1
DEBUG: Commits limit = null
DEBUG: Autodiscovering GitHub repositories
DEBUG: None of the discovered repositories matched the filter
DEBUG: Renovate exiting
Done in 19.16s.

[rarkins]

That's what I wanted to avoid. If they wrap it in /.../ then we need to validate it as regex and throw an error

[secustor]

new output:

DEBUG: Adding token authentication for api.github.com to hostRules
DEBUG: Using baseDir: /tmp/renovate
DEBUG: Using cacheDir: /tmp/renovate/cache
DEBUG: Initializing Renovate internal cache into /tmp/renovate/cache/renovate/renovate-cache-v1
DEBUG: Commits limit = null
DEBUG: Autodiscovering GitHub repositories
ERROR: Failed to parse regex pattern
       "autodiscoverFilter": "/secustor/renovate.**/"
DEBUG: Renovate exiting
 INFO: Renovate is exiting with a non-zero code due to the following logged errors
       "loggerErrors": [
         {
           "name": "renovate",
           "level": 50,
           "logContext": "BVXKuSQ9RE7oWF7FrLw8u",
           "autodiscoverFilter": "/secustor/renovate.**/",
           "msg": "Failed to parse regex pattern"
         }
       ]

[renovate-release]

🎉 This PR is included in version 31.30.0 🎉

The release is available on:

• GitHub release
• 31.30.0

Your semantic-release bot 📦🚀

[astellingwerf]

This expression isn't wrong per se, but I would consider it confusing.