Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ruby): ensure strict null check #13278

Merged
merged 16 commits into from
Jan 5, 2022
Merged

refactor(ruby): ensure strict null check #13278

merged 16 commits into from
Jan 5, 2022

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes:

  • Fix strict null errors

Context:

Ref: #12869

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice reviewed Dec 24, 2021
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs test / lint fixes

lib/versioning/ruby/index.ts Outdated Show resolved Hide resolved
lib/versioning/ruby/range.ts Show resolved Hide resolved
@RahulGautamSingh RahulGautamSingh marked this pull request as draft December 31, 2021 06:55
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review December 31, 2021 07:10
@RahulGautamSingh RahulGautamSingh mentioned this pull request Jan 3, 2022
Merged
6 tasks
viceice
viceice previously approved these changes Jan 4, 2022
View reviewed changes
viceice
viceice reviewed Jan 4, 2022
View reviewed changes
tsconfig.strict.json Outdated Show resolved Hide resolved
@viceice viceice enabled auto-merge (squash) January 4, 2022 09:52
@viceice viceice merged commit 0331116 into renovatebot:main Jan 5, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 31.19.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@zharinov zharinov mentioned this pull request Jan 12, 2022
Closed
24 tasks
@RahulGautamSingh RahulGautamSingh deleted the refactor(ruby)/ensure-strict-null-check branch January 12, 2022 05:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RahulGautamSingh @renovate-release @viceice @rarkins