Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix preset layout #13377

Merged
merged 2 commits into from
Jan 5, 2022
Merged

docs: fix preset layout #13377

merged 2 commits into from
Jan 5, 2022

Conversation

viceice
Copy link
Member

@viceice viceice commented Jan 5, 2022

Changes:

  • add newline after preset json
  • declare preset json as json

Context:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

- add newline after preset json
- declare preset json as json
@HonkingGoose

This comment has been minimized.

Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me, just from looking at it.

I would like to know if this actually works before merging it, but I don't think there's a way that's easy enough for me to do myself...

@viceice
Copy link
Member Author

viceice commented Jan 5, 2022

Looks okay to me, just from looking at it.

I would like to know if this actually works before merging it, but I don't think there's a way that's easy enough for me to do myself...

before:

### config:base

Default base configuration for all languages

```
{
  "extends": [
    ":dependencyDashboard",
    ":semanticPrefixFixDepsChoreOthers",
    ":ignoreModulesAndTests",
    ":autodetectPinVersions",
    ":prHourlyLimit2",
    ":prConcurrentLimit10",
    "group:monorepos",
    "group:recommended",
    "workarounds:all"
  ]
}
```
----

### config:js-app

after:

### config:base

Default base configuration for all languages

```json
{
  "extends": [
    ":dependencyDashboard",
    ":semanticPrefixFixDepsChoreOthers",
    ":ignoreModulesAndTests",
    ":autodetectPinVersions",
    ":prHourlyLimit2",
    ":prConcurrentLimit10",
    "group:monorepos",
    "group:recommended",
    "workarounds:all"
  ]
}
```

----

### config:js-app

@HonkingGoose
Copy link
Collaborator

That looks a lot better! 🥳

@viceice viceice enabled auto-merge (squash) January 5, 2022 10:30
@viceice viceice merged commit 6d5f4a5 into main Jan 5, 2022
@viceice viceice deleted the viceice-patch-2 branch January 5, 2022 10:50
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 31.19.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Markdown generation script so output is correct
4 participants