Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative URLs to our docs pages, instead of https://docs.renovatebot.com/ #13400

Closed
HonkingGoose opened this issue Jan 6, 2022 · 4 comments · Fixed by #26044
Closed

Use relative URLs to our docs pages, instead of https://docs.renovatebot.com/ #13400

HonkingGoose opened this issue Jan 6, 2022 · 4 comments · Fixed by #26044
Assignees
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:docs Documentation

Comments

@HonkingGoose
Copy link
Collaborator

HonkingGoose commented Jan 6, 2022

What would you like Renovate to be able to do?

Many of our internal documentation links are hard-coded to our documentation page domain. For example in docs/usage/config-presets.md:

- Browse [Renovate's default presets](https://docs.renovatebot.com/presets-default/) to find any that are useful to you

Using relative links 1 would have the following benefits:

  • Makes the documentation Markdown files self-referencing (which makes the published docs bundle on GitHub releases actually usable standalone, I hope)
  • Makes it easier to preview the documentation when running mkdocs serve on the docs publishing repo, as you can click on all the internal links without being taken to the production server on https://docs.renovatebot.com/

If you have any ideas on how this should be implemented, please tell us here.

I'll need advice on how to make the changes in a safe way, and how to test my work before putting it live on the main repository. I'd like to avoid breaking the links while I'm working on this change if at all possible. 🙈

Edit: VS Code can now check if Markdown links are correct. Go to VS Code changelog v1.67, languages and scroll down to read about the new Markdown language features.

MkDocs manual about linking to pages

Is this a feature you are interested in implementing yourself?

Maybe

Footnotes

  1. https://developer.mozilla.org/en-US/docs/Learn/HTML/Introduction_to_HTML/Creating_hyperlinks#absolute_versus_relative_urls

@HonkingGoose HonkingGoose added type:feature Feature (new functionality) status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage type:docs Documentation and removed type:feature Feature (new functionality) labels Jan 6, 2022
@HonkingGoose HonkingGoose self-assigned this May 12, 2022
@HonkingGoose HonkingGoose removed their assignment May 18, 2022
@rarkins rarkins added priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:ready and removed priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started labels Nov 25, 2022
@rarkins
Copy link
Collaborator

rarkins commented Nov 25, 2022

If we need to experiment to get it right, it's ok to have some temporarily broken links

@HonkingGoose HonkingGoose added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others and removed priority-4-low Low priority, unlikely to be done unless it becomes important to more people labels May 31, 2023
@HonkingGoose HonkingGoose self-assigned this May 31, 2023
@HonkingGoose HonkingGoose removed their assignment Jul 17, 2023
@HonkingGoose
Copy link
Collaborator Author

I've done what I can for this issue. I'll let somebody else do the rest. 😉

@HonkingGoose
Copy link
Collaborator Author

@viceice viceice mentioned this issue Nov 10, 2023
6 tasks
@viceice viceice mentioned this issue Nov 29, 2023
6 tasks
@viceice viceice self-assigned this Nov 29, 2023
@viceice viceice added the status:in-progress Someone is working on implementation label Nov 29, 2023
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 37.76.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:docs Documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants