Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pip_requirements): added support for packages from a git repository #13414

Merged
merged 5 commits into from Jan 18, 2022

Conversation

rwxd
Copy link
Contributor

@rwxd rwxd commented Jan 6, 2022

Changes:

  • under the pip_requirements added a regex to match pip packages from private repositories
  • added an if statement for a normal pypy package or a package from a git repository

I tested the regex with: https://regex101.com/r/JwOhNx/1

Context:

Closes #13397

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Jan 6, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs test for coverage

@rarkins
Copy link
Collaborator

rarkins commented Jan 7, 2022

Can you demo this working against a public repo?

@rwxd
Copy link
Contributor Author

rwxd commented Jan 7, 2022

Can you demo this working against a public repo?

I hopefully have time tomorrow to work on it, saw an error in a test PR.

@rarkins rarkins enabled auto-merge (squash) January 18, 2022 21:03
@rarkins rarkins merged commit 150d01a into renovatebot:main Jan 18, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 31.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pip Requirements from a private Repository via SSH
6 participants