fix(aws-machine-image): lazily load ec2client

[JamieMagee]

Changes:

• Unifying the versions of @aws-sdk/* packages
• Introducing the Lazy class for lazily loading expensive calls
• Lazily loading EC2Client in the constructor for AwsMachineImageDataSource

Context:

I attempted a couple of different fixes for this:

• Mocking HTTP calls with nock
• Setting up mockClient from aws-sdk-client-mock globally
• Creating a heap dump and examining it

In the end, lazily loading EC2Client was the only fix I could get to work reliably, with the smallest code changes. I also think that Lazy could come in useful elsewhere in the codebase.

Closes #13389

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[JamieMagee]

I can't request a review from @markussiebert, but tagging for visibility as you created this datasource.

[JamieMagee]

Rebased and accidentally invalidated the reviews 😭

[renovate-release]

🎉 This PR is included in version 31.21.2 🎉

The release is available on:

• GitHub release
• 31.21.2

Your semantic-release bot 📦🚀

[HonkingGoose]

Are we properly grouping the @aws-sdk/client-ec2, @aws-sdk/client-ecr and @aws-sdk/client-s3 packages in our renovatebot/.github rules, or in our own repo's renovate.json file?

Is there a way to prevent these packages to get out of sync with each other?

[viceice]

@HonkingGoose hey are grouped, but they need dashborad aproval. They got out of sync, because some are added later in a PR and the main branch was already on a newer version.

[HonkingGoose]

@HonkingGoose they are grouped, but they need dashborad aproval. They got out of sync, because some are added later in a PR and the main branch was already on a newer version.

Are you sure these packages are grouped together???

Quote from our renovatebot/github/default.json ¹ file:

    {
      "description": "Require approval for aws-sdk as it updates too often",
      "matchDatasources": ["npm"],
      "matchPackageNames": ["aws-sdk"],
      "matchPackagePatterns": ["^@aws-sdk\\/"],
      "dependencyDashboardApproval": true
    },

I do not see anything here that actually groups the aws-sdk packages together?

Footnotes

1. https://github.com/renovatebot/.github/blob/03cb56ff31a80b78b224e6024508007f502d77b6/default.json#L80-L86 ↩

[viceice]

yes:

renovate/lib/config/presets/internal/monorepo.ts

Line 24 in 2e258d8

'aws-sdk-js-v3': 'https://github.com/aws/aws-sdk-js-v3',

[HonkingGoose]

That line only groups any aws-sdk-js-v3 packages, I think.

Would it be a good idea to have a patternGroups entry that puts these packages into one group?

• @aws-sdk/client-ec2
• @aws-sdk/client-ecr
• @aws-sdk/client-s3

renovate/lib/config/presets/internal/monorepo.ts

Lines 194 to 203 in 2e258d8

	const patternGroups = {
	babel6: '^babel6$',
	clarity: ['^@cds/', '^@clr/'],
	wordpress: '^@wordpress/',
	angularmaterial: ['^@angular/material', '^@angular/cdk'],
	'aws-java-sdk': '^com.amazonaws:aws-java-sdk-',
	'aws-java-sdk-v2': '^software.amazon.awssdk:',
	embroider: '^@embroider/',
	fullcalendar: '^@fullcalendar/',
	};

[viceice]

@HonkingGoose They are grouped via sourceUrl, checkout https://www.npmjs.com/package/@aws-sdk/client-ec2. All @aws-sdk/* js pacvkages are published from https://github.com/aws/aws-sdk-js-v3

Lets move this to a discussion if you need further clarification.