Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): replace secrets in global config #13445

Merged
merged 13 commits into from Jan 28, 2022

Conversation

Chumper
Copy link
Contributor

@Chumper Chumper commented Jan 9, 2022

Reapplies #12138 with added test cases and additional parameters.
Default behaviour is the same, secrets getting deleted.
New behaviour is that secrets are applied without deleting them globally

Changes:

Applies secret in global config.

Context:

#12387
#12389
#12138
Closes #12144

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Chumper and others added 2 commits January 9, 2022 14:07
Reapplies renovatebot#12138 with added test cases and additional parameters.
Default behaviour is the same, secrets getting deleted.
New behaviour is that secrets are applied without deleting them globally
lib/config/secrets.spec.ts Outdated Show resolved Hide resolved
lib/config/secrets.spec.ts Outdated Show resolved Hide resolved
lib/config/secrets.ts Show resolved Hide resolved
@Chumper Chumper requested a review from viceice January 10, 2022 23:00
lib/workers/repository/index.ts Outdated Show resolved Hide resolved
lib/config/secrets.ts Outdated Show resolved Hide resolved
@Chumper Chumper requested a review from viceice January 20, 2022 15:18
lib/config/secrets.ts Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Jan 27, 2022

CLA assistant check
All committers have signed the CLA.

@rarkins rarkins enabled auto-merge (squash) January 28, 2022 13:06
auto-merge was automatically disabled January 28, 2022 13:31

Pull Request is not mergeable

@rarkins rarkins merged commit c34c1a7 into renovatebot:main Jan 28, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 31.60.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secrets in the globalConfig (e.g. customEnvVariables) are not replaced
5 participants