feat(migrations): split #13499
Merged
feat(migrations): split #13499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieMagee
reviewed
Jan 12, 2022
lib/config/migrations/custom/enabled-managers-migration.spec.ts
Outdated
Show resolved
Hide resolved
JamieMagee
reviewed
Jan 12, 2022
| override run(value): void { | ||
| const rebaseConflictedPrs = this.get('rebaseConflictedPrs'); | ||
|
|
||
| if (rebaseConflictedPrs !== false) { |
There was a problem hiding this comment.
IMO the double negative is a little confusing
Suggested change
| if (rebaseConflictedPrs !== false) { | |
| if (rebaseConflictedPrs === true) { |
or
Suggested change
| if (rebaseConflictedPrs !== false) { | |
| if (rebaseConflictedPrs) { |
There was a problem hiding this comment.
Now I re-read this, I realise that rebaseConflictedPrs is boolean | undefined so you'd need rebaseConflictedPrs === true || rebaseConflictedPrs === undefined. Gotta love that trinary logic 😅
JamieMagee
reviewed
Jan 12, 2022
JamieMagee
previously approved these changes
Jan 12, 2022
Co-authored-by: Jamie Magee <jamie.magee@gmail.com>
JamieMagee
approved these changes
Jan 13, 2022
|
🎉 This PR is included in version 31.24.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Context:
Documentation
How I've tested my work
I have verified these changes via: