Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/flux): Update system manifests. #13675

Merged
merged 15 commits into from Jan 29, 2022

Conversation

danports
Copy link
Contributor

@danports danports commented Jan 20, 2022

Changes

The flux manager can now detect and automatically update Flux system manifests.

Context

Renovating the system manifests allows Flux to update itself automatically once Renovate's changes are merged. Modeled on the Flux GitHub action.

Documentation

  • I have updated the documentation, or
  • No documentation update is required

Testing

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

lib/manager/flux/index.ts Outdated Show resolved Hide resolved
lib/manager/flux/index.ts Outdated Show resolved Hide resolved
@rarkins
Copy link
Collaborator

rarkins commented Jan 20, 2022

image

:)

@danports
Copy link
Contributor Author

@rarkins I'm too lazy to update dependencies manually - it's easier to open more Renovate PRs... 😂

@danports danports requested a review from viceice January 20, 2022 14:14
@danports danports marked this pull request as ready for review January 22, 2022 17:06
@danports
Copy link
Contributor Author

Is there a straightforward way to test flux running in a sidecar container before this is merged? I've only tested by manually installing flux in my dev container so far.

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkout the buildpack.ts file in util/exec for how to install the tool. Then you can run yarn start with binarySource=docker

lib/manager/flux/artifacts.ts Outdated Show resolved Hide resolved
lib/manager/flux/artifacts.ts Outdated Show resolved Hide resolved
@danports
Copy link
Contributor Author

Verified that everything works when binarySource is docker. 🥳 I think we are ready for 🚀 here unless there are some more nits to address.

@danports danports requested a review from viceice January 23, 2022 01:51
lib/manager/flux/artifacts.ts Show resolved Hide resolved
lib/manager/flux/artifacts.ts Show resolved Hide resolved
lib/manager/flux/extract.ts Outdated Show resolved Hide resolved
lib/manager/flux/index.ts Outdated Show resolved Hide resolved
lib/manager/flux/index.ts Outdated Show resolved Hide resolved
rarkins
rarkins previously approved these changes Jan 24, 2022
@danports
Copy link
Contributor Author

@viceice Any additional feedback for me to address?

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for docs review 🙃

@viceice viceice changed the title feat: Renovate Flux system manifests. feat(manager/flux): Support system manifests. Jan 28, 2022
@viceice viceice changed the title feat(manager/flux): Support system manifests. feat(manager/flux): Update system manifests. Jan 28, 2022
viceice
viceice previously approved these changes Jan 28, 2022
@danports danports dismissed stale reviews from viceice and rarkins via 3c54b09 January 29, 2022 01:36
@rarkins rarkins enabled auto-merge (squash) January 29, 2022 06:17
@rarkins rarkins merged commit 41f198c into renovatebot:main Jan 29, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 31.61.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@danports danports deleted the flux-autoupdate branch January 29, 2022 14:13
file: {
type: 'addition',
path: packageFileName,
contents: result.stdout,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This unfortunately also captures the output from install-tool

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants