Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support binarySource=install for bundler #13684

Closed
rarkins opened this issue Jan 20, 2022 · 7 comments · Fixed by #13780
Closed

Support binarySource=install for bundler #13684

rarkins opened this issue Jan 20, 2022 · 7 comments · Fixed by #13780
Assignees
Labels
manager:bundler Bundler (Ruby) package manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Jan 20, 2022

What would you like Renovate to be able to do?

Support runtime install of bundler when binarySource=install

If you have any ideas on how this should be implemented, please tell us here.

Currently we install bundler using gem install...:

const preCommands = [
'ruby --version',
`gem install bundler${bundlerVersion}`,
];

We probably could run gem install into our full container, but maybe we should add install-tool bundler?

Is this a feature you are interested in implementing yourself?

Maybe

@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others manager:bundler Bundler (Ruby) package manager status:requirements Full requirements are not yet known, so implementation should not be started labels Jan 20, 2022
@viceice
Copy link
Member

viceice commented Jan 20, 2022

We should use install-tool for all to simplify code

@rarkins
Copy link
Collaborator Author

rarkins commented Jan 21, 2022

We are using install-gem for bundler: https://github.com/containerbase/buildpack/blob/26cf7d7273177157cfa1d09af62e8a8e8a189e83/test/ruby/Dockerfile#L65

Do you think we should add a install-tool wrapper for each "well-known" tool like this, or adapt our Renovate code to supply separate tool/gem/pip/npm lists? The challenge with that is ordering

@rarkins
Copy link
Collaborator Author

rarkins commented Jan 21, 2022

Blocked by containerbase/base#251

@rarkins rarkins added status:blocked Issue is blocked by another issue or external requirement and removed status:requirements Full requirements are not yet known, so implementation should not be started labels Jan 21, 2022
@viceice viceice added status:ready and removed status:blocked Issue is blocked by another issue or external requirement labels Jan 24, 2022
@viceice
Copy link
Member

viceice commented Jan 24, 2022

now unblocked

@rarkins
Copy link
Collaborator Author

rarkins commented Jan 24, 2022

Which versions of renovate/ruby images would support install-tool bundler ?

@rarkins
Copy link
Collaborator Author

rarkins commented Jan 24, 2022

Problem:

❯ docker run --rm -it renovate/ruby:2.6.4 /bin/bash
ubuntu@789553dfb959:/$ install-tool bundler 1.17.2
Installing tool bundler v1.17.2
Fetching bundler-1.17.2.gem
Successfully installed bundler-1.17.2
1 gem installed
Bundler version 1.17.2
ubuntu@789553dfb959:/$ bundle --version
bash: bundle: command not found
ubuntu@789553dfb959:/$ bundler --version
Bundler version 1.17.2
ubuntu@789553dfb959:/$ 

Renovate today calls bundle and not bundler. Not sure if we break anyone self-hosted if we switch to bundle from bundler

@rarkins rarkins self-assigned this Jan 24, 2022
@rarkins rarkins added status:in-progress Someone is working on implementation and removed status:ready labels Jan 24, 2022
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 31.52.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:bundler Bundler (Ruby) package manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants