feat(helmv3): support for private repositories and registries in lock files #13726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
secustor
changed the title
viceice
reviewed
Jan 21, 2022
lib/manager/helmv3/artifacts.ts
Outdated
| // get repositories and registries defined in the package file | ||
| const packages = yaml.load(newPackageFileContent) as ChartDefinition; //TODO #9610 | ||
| const locks = yaml.load( | ||
| existingLockFileContent.toString() |
There was a problem hiding this comment.
Why toString? Should not be required.
There was a problem hiding this comment.
existingLockFileContent is a Buffer and the load function only accepts the content as string.
There was a problem hiding this comment.
Add utf-8 encoding to the readLocalFile then you'll get a string. 😉
There was a problem hiding this comment.
My thought has been that it is "safer" to compare the Buffers at https://github.com/renovatebot/renovate/pull/13726/files#diff-c2af1ba9c74f4a977e199d28c1e555ace1ce248ab708c0a5874fa5e5e2cd13c7R160, as encoding can not affect it then.
But works for me.
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
viceice
approved these changes
Jan 24, 2022
rarkins
approved these changes
Jan 24, 2022
|
🎉 This PR is included in version 31.51.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Adds login commands for private registries and repositories, if a fitting host rule has been found
Context:
Closes #13524
Closes #10659
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via:
https://github.com/secustor/renovate-helm-oci