New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(git): Split commitFiles function into 3 phases #13821
refactor(git): Split commitFiles function into 3 phases #13821
Conversation
…/renovate; branch 'main' of github.com:renovatebot/renovate into refactor/git-extract-push-phase
🎉 This PR is included in version 31.57.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
const { localDir } = GlobalConfig.get(); | ||
await syncGit(); | ||
logger.debug(`Committing files to branch ${branchName}`); | ||
logger.debug(`Preparing files for commiting to branch ${branchName}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd expect one more 't' in the last verb. Also see https://www.spellchecker.net/misspellings/commiting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, thanks. I'll fix it with an upcoming PR
Changes:
prepareCommit
and make it return filtered file listpushCommit
fetchCommit
and make it return commit SHAContext:
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: