Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix codeql excludes #13928

Merged
merged 5 commits into from Jan 31, 2022
Merged

ci: fix codeql excludes #13928

merged 5 commits into from Jan 31, 2022

Conversation

viceice
Copy link
Member

@viceice viceice commented Jan 31, 2022 •
edited

Changes:

  • fix excludes to reduce false positives from fixtures
  • speedup analysis
    It seems the ignore-paths config was wrong

Context:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

rarkins
rarkins previously approved these changes Jan 31, 2022
View reviewed changes
rarkins
rarkins previously approved these changes Jan 31, 2022
View reviewed changes
@viceice viceice requested a review from rarkins January 31, 2022 13:47
@viceice viceice marked this pull request as ready for review January 31, 2022 13:48
@viceice viceice enabled auto-merge (squash) January 31, 2022 13:49
@viceice viceice merged commit 493fd75 into main Jan 31, 2022
@viceice viceice deleted the viceice-patch-1 branch January 31, 2022 14:00
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 31.64.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@viceice @renovate-release @rarkins