Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove default maven central registry #13950

Merged
merged 8 commits into from Feb 5, 2022

Conversation

Chumper
Copy link
Contributor

@Chumper Chumper commented Feb 1, 2022

Changes:

Removes that the maven central url is added by default to all maven dependencies.

Context:

Closes #13925

According to the maven repository page this is a valid approach.

 By default, Maven will download from the central repository.

To me this means that if a repository is defined, it will take the place of the default.
In the test we have a simple pom which declares a repository, which will result in the maven repository not being added to the dependency.

However this could be a breaking change for repos that do not follow this approach but instead use maven central as default and add repositories on top of that.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice February 5, 2022 06:40
@viceice viceice enabled auto-merge (squash) February 5, 2022 07:08
@viceice viceice merged commit ead221d into renovatebot:main Feb 5, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 31.66.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Chumper Chumper deleted the fix/defaultMavenCentral branch February 5, 2022 14:50
rarkins added a commit that referenced this pull request Feb 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

defaultRegistryUrls does not work when the manager provides a custom defaultUrl
4 participants