Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager/helm-requirements): ensure currentValue is a string #13979

Conversation

secustor
Copy link
Collaborator

@secustor secustor commented Feb 3, 2022

Changes:

Convert currentValue to string if currentValue is defined.

Context:

If versions like 1.4 are defined helm-requirements js-yaml parse them as number and not as string
Prevents:

       "err": {
         "message": "constraint?.startsWith is not a function",
         "stack": "TypeError: constraint?.startsWith is not a function\n    at Object.isSingleVersion (/usr/src/app/node_modules/renovate/lib/versioning/npm/index.ts:39:18)\n    at lookupUpdates (/usr/src/app/node_modules/renovate/lib/workers/repository/process/lookup/index.ts:318:43)\n    at fetchDepUpdates (/usr/src/app/node_modules/renovate/lib/workers/repository/process/fetch.ts:37:32)\n    at /usr/src/app/node_modules/p-map/index.js:57:22"
       }

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@secustor secustor requested a review from viceice February 3, 2022 14:11
rarkins
rarkins previously approved these changes Feb 3, 2022
@viceice viceice requested a review from rarkins February 3, 2022 14:59
@rarkins rarkins enabled auto-merge (squash) February 4, 2022 05:12
@rarkins rarkins merged commit 2a013b3 into renovatebot:main Feb 4, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 31.66.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@secustor secustor deleted the fix_helm_requiremnts_handle_number_current_value branch February 4, 2022 08:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants